kou commented on PR #38202: URL: https://github.com/apache/arrow/pull/38202#issuecomment-1758466623
In general, we should not add our workaround to only our copy as much as possible. Instead, we should fix a problem in upstream and our side as much as possible. It's for maintainability and Conan related tests' propose. We want to avoid problems as much as possible when we update https://github.com/conan-io/conan-center-index/tree/master/recipes/arrow as a post release task. If we have changes that exist only in our side, we may not be able to detect problems in our Conan related CI jobs. In this case, it seems that there is a fix in upstream: https://github.com/conan-io/conan-center-index/pull/19803 How about synchronizing `ci/conan/` with https://github.com/conan-io/conan-center-index/tree/master/recipes/arrow instead of this change? We can use `ci/conan/merge_upstream.sh` for it. I can do it. But if anyone wants to do it, I can help the person. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
