assignUser commented on code in PR #38195:
URL: https://github.com/apache/arrow/pull/38195#discussion_r1357031841
##########
r/tools/nixlibs.R:
##########
@@ -736,11 +738,6 @@ with_cloud_support <- function(env_var_list) {
cat("**** ", start_msg, " support ", msg, "; building with ", off_flags,
"\n")
}
- # Check the features
Review Comment:
I explained it in the commit message which seems redundant now as it doesn't
show up unless you check ^^
The use of cmake here is correct in the fail fast way and matches the actual
build, which the test compilation would not be.
On the other hand the test compilation does not require cmake and is used to
get the binary so we would need cmake just to check for the deps which is an
unnecessary dependency.
So I removed the comment because there is no change necessary!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
