assignUser commented on code in PR #38115:
URL: https://github.com/apache/arrow/pull/38115#discussion_r1357043620
##########
r/tools/nixlibs.R:
##########
@@ -103,6 +104,42 @@ download_binary <- function(lib) {
}
libfile <- NULL
}
+ # Explicitly setting the env var to "false" will skip checksum validation
+ # e.g. in case the included checksums are stale.
+ skip_checksum <- env_is("ARROW_R_ENFORCE_CHECKSUM", "false")
+ enforce_checksum <- env_is("ARROW_R_ENFORCE_CHECKSUM", "true")
+ # validate binary checksum for CRAN release only
+ if (!skip_checksum && dir.exists(checksum_path) && is_release ||
+ enforce_checksum) {
+ checksum_file <- sub(".+/bin/(.+\\.zip)", "\\1\\.sha512", binary_url)
Review Comment:
I do the refactor here: https://github.com/apache/arrow/pull/38236
will add these suggestion there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
