kou commented on a change in pull request #9096:
URL: https://github.com/apache/arrow/pull/9096#discussion_r554240959
##########
File path: docker-compose.yml
##########
@@ -120,9 +117,113 @@ x-hierarchy:
# helper services
- impala
- postgres
+ - python-wheel-manylinux-2010
+ - python-wheel-manylinux-2014
+ - python-wheel-manylinux-test
+ - python-wheel-windows-vs2017
+ - python-wheel-windows-test
+
+volumes:
+ conda-ccache:
+ name: ${ARCH}-conda-ccache
+ debian-ccache:
+ name: ${ARCH}-debian-${DEBIAN}-ccache
+ ubuntu-ccache:
+ name: ${ARCH}-ubuntu-${UBUNTU}-ccache
+ fedora-ccache:
+ name: ${ARCH}-fedora-${FEDORA}-ccache
+ debian-rust:
+ name: ${ARCH}-debian-${DEBIAN}-rust
+ maven-cache:
+ name: maven-cache
+ wheel-manylinux1-ccache:
Review comment:
How about prepend `python-` because `python-` exists in related names?
##########
File path: docker-compose.yml
##########
@@ -120,9 +117,113 @@ x-hierarchy:
# helper services
- impala
- postgres
+ - python-wheel-manylinux-2010
+ - python-wheel-manylinux-2014
+ - python-wheel-manylinux-test
+ - python-wheel-windows-vs2017
+ - python-wheel-windows-test
+
+volumes:
+ conda-ccache:
+ name: ${ARCH}-conda-ccache
+ debian-ccache:
+ name: ${ARCH}-debian-${DEBIAN}-ccache
+ ubuntu-ccache:
+ name: ${ARCH}-ubuntu-${UBUNTU}-ccache
+ fedora-ccache:
+ name: ${ARCH}-fedora-${FEDORA}-ccache
+ debian-rust:
+ name: ${ARCH}-debian-${DEBIAN}-rust
+ maven-cache:
+ name: maven-cache
+ wheel-manylinux1-ccache:
+ name: centos-python-manylinux1-ccache
+ wheel-manylinux2010-ccache:
+ name: centos-python-manylinux2010-ccache
+ wheel-manylinux2014-ccache:
+ name: centos-python-manylinux2014-ccache
+ wheel-windows-clcache:
+ name: windows-wheel-clcache
services:
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux2010_x86_64?tab=tags
+ python-wheel-manylinux-2010:
+ image: ${REPO}:python-${PYTHON}-wheel-manylinux-2010
+ build:
+ args:
+ base: quay.io/pypa/manylinux2010_x86_64:2020-12-03-912b0de
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ context: .
+ dockerfile: ci/docker/wheel-manylinux-201x.dockerfile
Review comment:
How about prepend `python-` because `python-` exists in related names?
##########
File path: docker-compose.yml
##########
@@ -120,9 +117,113 @@ x-hierarchy:
# helper services
- impala
- postgres
+ - python-wheel-manylinux-2010
+ - python-wheel-manylinux-2014
+ - python-wheel-manylinux-test
+ - python-wheel-windows-vs2017
+ - python-wheel-windows-test
+
+volumes:
+ conda-ccache:
+ name: ${ARCH}-conda-ccache
+ debian-ccache:
+ name: ${ARCH}-debian-${DEBIAN}-ccache
+ ubuntu-ccache:
+ name: ${ARCH}-ubuntu-${UBUNTU}-ccache
+ fedora-ccache:
+ name: ${ARCH}-fedora-${FEDORA}-ccache
+ debian-rust:
+ name: ${ARCH}-debian-${DEBIAN}-rust
+ maven-cache:
+ name: maven-cache
+ wheel-manylinux1-ccache:
+ name: centos-python-manylinux1-ccache
+ wheel-manylinux2010-ccache:
+ name: centos-python-manylinux2010-ccache
+ wheel-manylinux2014-ccache:
+ name: centos-python-manylinux2014-ccache
+ wheel-windows-clcache:
+ name: windows-wheel-clcache
services:
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux2010_x86_64?tab=tags
+ python-wheel-manylinux-2010:
+ image: ${REPO}:python-${PYTHON}-wheel-manylinux-2010
+ build:
+ args:
+ base: quay.io/pypa/manylinux2010_x86_64:2020-12-03-912b0de
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ context: .
+ dockerfile: ci/docker/wheel-manylinux-201x.dockerfile
+ cache_from:
+ - ${REPO}:python-${PYTHON}-wheel-manylinux-2010
+ environment:
+ <<: *ccache
+ MANYLINUX_VERSION: 2010
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}wheel-manylinux2010-ccache:/ccache:delegated
+ command: /arrow/ci/scripts/wheel_manylinux_build.sh
+
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux2014_x86_64?tab=tags
+ python-wheel-manylinux-2014:
+ image: ${REPO}:python-${PYTHON}-wheel-manylinux-2014
+ build:
+ args:
+ base: quay.io/pypa/manylinux2014_x86_64:2020-11-11-bc8ce45
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ context: .
+ dockerfile: ci/docker/wheel-manylinux-201x.dockerfile
+ cache_from:
+ - ${REPO}:python-${PYTHON}-wheel-manylinux-2014
+ environment:
+ <<: *ccache
+ MANYLINUX_VERSION: 2014
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}wheel-manylinux2014-ccache:/ccache:delegated
+ command: /arrow/ci/scripts/wheel_manylinux_build.sh
+
+ python-wheel-manylinux-test:
+ image: python:${PYTHON}
+ shm_size: 2G
+ volumes:
+ - .:/arrow:delegated
+ command: /arrow/ci/scripts/wheel_manylinux_test.sh
+
+ python-wheel-windows-vs2017:
+ image: ${REPO}:python-${PYTHON}-wheel-windows-vs2017
+ build:
+ args:
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ context: .
+ dockerfile: ci/docker/wheel-windows-vs2017.dockerfile
+ # This should make the pushed images reusable, but the image gets rebuilt
+ # no matter
+ # cache_from:
+ # - mcr.microsoft.com/windows/servercore:ltsc2019
+ # - ${REPO}:wheel-windows-vs2017
+ volumes:
+ - "${DOCKER_VOLUME_PREFIX}wheel-windows-clcache:C:/clcache"
+ - type: bind
+ source: .
+ target: "C:/arrow"
+ command: arrow\\ci\\scripts\\wheel_windows_build.bat
+
+ python-wheel-windows-test:
+ image: python:${PYTHON}-windowsservercore-1809
+ volumes:
+ - type: bind
+ source: .
+ target: "C:/arrow"
+ command: arrow\\ci\\scripts\\wheel_windows_test.bat
Review comment:
How about moving `python-wheel-*` services into `...### Python ###...`
section?
##########
File path: docker-compose.yml
##########
@@ -120,9 +117,113 @@ x-hierarchy:
# helper services
- impala
- postgres
+ - python-wheel-manylinux-2010
+ - python-wheel-manylinux-2014
+ - python-wheel-manylinux-test
+ - python-wheel-windows-vs2017
+ - python-wheel-windows-test
+
+volumes:
+ conda-ccache:
+ name: ${ARCH}-conda-ccache
+ debian-ccache:
+ name: ${ARCH}-debian-${DEBIAN}-ccache
+ ubuntu-ccache:
+ name: ${ARCH}-ubuntu-${UBUNTU}-ccache
+ fedora-ccache:
+ name: ${ARCH}-fedora-${FEDORA}-ccache
+ debian-rust:
+ name: ${ARCH}-debian-${DEBIAN}-rust
+ maven-cache:
+ name: maven-cache
+ wheel-manylinux1-ccache:
+ name: centos-python-manylinux1-ccache
+ wheel-manylinux2010-ccache:
+ name: centos-python-manylinux2010-ccache
+ wheel-manylinux2014-ccache:
+ name: centos-python-manylinux2014-ccache
+ wheel-windows-clcache:
+ name: windows-wheel-clcache
services:
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux2010_x86_64?tab=tags
+ python-wheel-manylinux-2010:
+ image: ${REPO}:python-${PYTHON}-wheel-manylinux-2010
+ build:
+ args:
+ base: quay.io/pypa/manylinux2010_x86_64:2020-12-03-912b0de
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ context: .
+ dockerfile: ci/docker/wheel-manylinux-201x.dockerfile
+ cache_from:
+ - ${REPO}:python-${PYTHON}-wheel-manylinux-2010
+ environment:
+ <<: *ccache
+ MANYLINUX_VERSION: 2010
+ volumes:
+ - .:/arrow:delegated
+ - ${DOCKER_VOLUME_PREFIX}wheel-manylinux2010-ccache:/ccache:delegated
+ command: /arrow/ci/scripts/wheel_manylinux_build.sh
Review comment:
How about prepend `python_` because `python-` exists in related names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
