niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1357697046
##########
cpp/src/gandiva/cmake/GenerateBitcode.cmake:
##########
Review Comment:
@kou I gave this a try, and CMake told me the following error:
```
CMake Error at src/gandiva/precompiled/CMakeLists.txt:33 (generate_bitcode):
Unknown CMake command "generate_bitcode".
```
Sorry I am not very familiar with CMake, could you please help to confirm
some changes here:
1) in your diff, `provide_find_module` is renamed to `provide_cmake_module`
in `cpp/cmake_modules/ThirdpartyToolchain.cmake`, in my local codebase, I don't
see such change (`provide_find_module` is still there), and I assume I don't
need to change the file `ThirdpartyToolchain.cmake`, is it correct?
2) I found the code in `ThirdpartyToolchain.cmake` like this:
```
macro(provide_find_module PACKAGE_NAME ARROW_CMAKE_PACKAGE_NAME)
set(module_ "${CMAKE_SOURCE_DIR}/cmake_modules/Find${PACKAGE_NAME}.cmake")
```
It seems `Find` prefix will automatically appended. Do I need to name the
CMake file as `cpp/cmake_modules/GandivaAddBitcode.cmake` or
`cpp/cmake_modules/FindGandivaAddBitcode.cmake`? (I actually tried both, but
none of them worked for me, and the same error was reported saying `Unknown
CMake command "generate_bitcode".`
3) I assume I should name the file to `FindGandivaAddBitcode.cmake`
according to the code, but should I change the
`include("${CMAKE_CURRENT_LIST_DIR}/GandivaAddBitcode.cmake")` to be
`include("${CMAKE_CURRENT_LIST_DIR}/FindGandivaAddBitcode.cmake")` in
`GandivaConfig.cmake.in`?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
