js8544 commented on code in PR #37100:
URL: https://github.com/apache/arrow/pull/37100#discussion_r1357849884
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -492,11 +492,32 @@ Result<std::unique_ptr<KernelState>>
MinMaxInit(KernelContext* ctx,
return visitor.Create();
}
+struct AnyExceptDictionaryMatcher : TypeMatcher {
Review Comment:
I think there's a more general approach for matching with non-dictionary
types. We can add a `NotMatcher` in kernel.cc with constructor
```explicit NotMatcher(std::shared_ptr<TypeMatcher> base_matcher)```
and returns `!base_matcher.Matches(type)`. And when registering kernels we
will use `Not(SameTypeId(Type::DICTIONARY))`. It will be useful if some other
kernels face the same issue.
Edit: See below. We probably don't need this function at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
