WillAyd commented on code in PR #1203:
URL: https://github.com/apache/arrow-adbc/pull/1203#discussion_r1358911514
##########
c/cmake_modules/BuildUtils.cmake:
##########
@@ -467,15 +467,13 @@ function(ADD_BENCHMARK REL_BENCHMARK_NAME)
target_link_libraries(${BENCHMARK_NAME} PRIVATE
${ADBC_BENCHMARK_LINK_LIBS})
endif()
add_dependencies(benchmark ${BENCHMARK_NAME})
- set(NO_COLOR "--color_print=false")
Review Comment:
This option doesn't exist for benchmark at all; benchmark documents having
color output by default, but I didn't see a command line switch to toggle that.
Figured this can be safely removed
##########
c/cmake_modules/BuildUtils.cmake:
##########
@@ -467,15 +467,13 @@ function(ADD_BENCHMARK REL_BENCHMARK_NAME)
target_link_libraries(${BENCHMARK_NAME} PRIVATE
${ADBC_BENCHMARK_LINK_LIBS})
endif()
add_dependencies(benchmark ${BENCHMARK_NAME})
- set(NO_COLOR "--color_print=false")
Review Comment:
https://google.github.io/benchmark/user_guide.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
