amoeba opened a new pull request, #38267:
URL: https://github.com/apache/arrow/pull/38267

   ### Rationale for this change
   
   It's useful when troubleshooting issues with Arrow's S3 filesystem 
implementation to raise the log level. Currently, this can only be done in C++ 
and Python, but not from R. In addition, the log level can only be set during 
S3 initialization and not directly so the user has to introduce explicit S3 
initialization code to turn on logging and must make sure this code is called 
before S3 initialization.
   
   While discussing exposing control of log level to R, we realized that 
allowing the log level to be controlled by environment variable may be more 
intuitive and useful and would just be a good addition for C++, Python, and R. 
   
   ### What changes are included in this PR?
   
   - A new environment variable `AWS_S3_LOG_LEVEL` with documentation for 
controlling S3 log level
   - Updated documentation for C++, Python, and R
   - A new `InitializeS3()` as a quality-of-life thing for C++ users. Feel free 
to ask me to remove this.
   
   No changes are needed directly for Python and R because these implementation 
uses the internal implicit initializer `EnsureS3Initialized` rather than the 
explicit form, `InitializeS3`. And it's the behavior of the 
`EnsureS3Initialized` routine that's changed here.
   
   ### Are these changes tested?
   
   Yes. I added a unit test for the new `GetS3LogLevelFromEnvOrDefault` and 
tested from Python and R manually. I didn't add a test to make sure the 
underlying `AwsInstance` gets set up correctly because it looked like it would 
require a refactor and didn't seem worth it.
   
   ### Are there any user-facing changes?
   
   Yes. A new way to turn on logging for S3 and matching docs in C++, Python, 
and R.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to