alamb commented on code in PR #7817:
URL: https://github.com/apache/arrow-datafusion/pull/7817#discussion_r1359317870
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -38,6 +38,113 @@ use tokio::task::JoinSet;
use super::metrics::BaselineMetrics;
use super::{ExecutionPlan, RecordBatchStream, SendableRecordBatchStream};
+/// Creates a stream from a collection of producing tasks, routing panics to
the stream
Review Comment:
```suggestion
/// Creates a stream from a collection of producing tasks, routing panics to
the stream.
///
/// Note that this is similar to [`ReceiverStream` from tokio-stream], with
the differences being:
///
/// 1. Methods to bound and "detach" tasks (`spawn()` and
`spawn_blocking()`).
///
/// 2. Propagates panics, whereas the `tokio` version doesn't propagate
panics to the receiver.
///
/// 3. Automatically cancels any outstanding tasks when the receiver stream
is dropped.
///
/// [`ReceiverStream` from tokio-stream]:
https://docs.rs/tokio-stream/latest/tokio_stream/wrappers/struct.ReceiverStream.html
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
