alamb commented on code in PR #7803:
URL: https://github.com/apache/arrow-datafusion/pull/7803#discussion_r1359318142
##########
datafusion/common/src/error.rs:
##########
@@ -478,9 +478,16 @@ macro_rules! with_dollar_sign {
/// plan_err!("Error {val}")
/// plan_err!("Error {val:?}")
macro_rules! make_error {
- ($NAME:ident, $ERR:ident) => {
+ ($NAME:ident, $NAME_RAW: ident, $ERR:ident) => {
Review Comment:
Can you please document in comments what `$NAME` and `$NAME_RAW` are and how
they are different?
my reading is that the `raw` is the name of an internal macro that gets
generated. I think it would help to document more clearly what the difference
in `plan_err!` and `plan_err_raw!` did (specifically that `plan_err` returns an
`Err(plan_err_raw)`
##########
datafusion/common/src/error.rs:
##########
@@ -493,16 +500,16 @@ macro_rules! make_error {
}
// Exposes a macro to create `DataFusionError::Plan`
-make_error!(plan_err, Plan);
+make_error!(plan_err, plan_err_raw, Plan);
Review Comment:
Maybe `plan_err_obj` or `plan_datafusion_error`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
