jackwener commented on code in PR #7785:
URL: https://github.com/apache/arrow-datafusion/pull/7785#discussion_r1360149190
##########
datafusion/expr/src/expr.rs:
##########
@@ -599,10 +600,13 @@ impl InSubquery {
}
}
-/// Placeholder
+/// Placeholder, representing bind parameter values such as `$1`.
+///
+/// The type of these parameters is inferred using
[`Expr::infer_placeholder_types`]
+/// or can be specified directly using `PREPARE` statements.
#[derive(Clone, PartialEq, Eq, Hash, Debug)]
pub struct Placeholder {
- /// The identifier of the parameter (e.g, $1 or $foo)
+ /// The identifier of the parameter, including the leading `$` (e.g,
`"$1"` or `"$foo'`)
Review Comment:
```suggestion
/// The identifier of the parameter, including the leading `$` (e.g,
`"$1"` or `"$foo"`)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
