felipecrv commented on PR #38265: URL: https://github.com/apache/arrow/pull/38265#issuecomment-1764505871
> @felipecrv I am validating but this seems to make the `test-build-vcpkg-win` build to fail on the maintenance branch: > > ``` > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(1970,1): error C2664: 'arrow::Status arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType>::ReplaceString(re2::StringPiece,arrow::TypedBufferBuilder<uint8_t,void> *) const': cannot convert argument 1 from 'std::string_view' to 're2::StringPiece' (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(1970,1): message : No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(2066,10): message : see declaration of 'arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType>::ReplaceString' (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(1962): message : while compiling class template member function 'arrow::Status arrow::compute::internal::`anonymous-namespace'::ReplaceSubstring<arrow::LargeStringType,arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType>>::Replace(arrow::compute::KernelContext *,const arrow::compute::ExecSpan &,const Replacer &,arrow::compute::ExecResult *)' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > with > [ > Replacer=arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType> > ] (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(1958): message : see reference to function template instantiation 'arrow::Status arrow::compute::internal::`anonymous-namespace'::ReplaceSubstring<arrow::LargeStringType,arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType>>::Replace(arrow::compute::KernelContext *,const arrow::compute::ExecSpan &,const Replacer &,arrow::compute::ExecResult *)' being compiled [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > with > [ > Replacer=arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType> > ] (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) > D:\a\crossbow\crossbow\arrow\cpp\src\arrow/compute/kernels/codegen_internal.h(1249): message : see reference to class template instantiation 'arrow::compute::internal::`anonymous-namespace'::ReplaceSubstring<arrow::LargeStringType,arrow::compute::internal::`anonymous-namespace'::RegexSubstringReplacer<arrow::LargeStringType>>' being compiled (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > D:/a/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc(2158): message : see reference to function template instantiation 'arrow::compute::ArrayKernelExec (__cdecl *arrow::compute::internal::GenerateVarBinaryToVarBinary<arrow::compute::internal::`anonymous-namespace'::ReplaceSubstringRegex,>(arrow::compute::internal::detail::GetTypeId))(arrow::compute::KernelContext *,const arrow::compute::ExecSpan &,arrow::compute::ExecResult *)' being compiled (compiling source file D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_21_cxx.cxx) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow_shared.vcxproj] > ``` > > See: https://github.com/ursacomputing/crossbow/actions/runs/6533642461/job/17739225267 Alright. I will push a fix now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
