ongchi commented on PR #7732: URL: https://github.com/apache/arrow-datafusion/pull/7732#issuecomment-1764588276
> Converting to draft as this PR is not waiting on feedback anymore. Please mark it ready to review when ready. > > I do realize when writing documentation, often deficiencies in the existing APIs become clearer > > One suggestion I had was to split out the changes to the documentation from the changes to how the traits work. > > > I think we should reorganize test cases in datafusion-expr and make some improvements by creating a test module. Currently, these tests do not cover all use cases. The tests may follow the order/structure from expression API documentation, which would make it easier to identify which parts needs to be improve. > > I agree -- @ongchi could you please file a follow on ticket describing this work? Perhaps it would be a good first step in updating how the traits worked: consolidate all the existing tests we do have, so the scope of the "to do" work becomes clear. Sure, I'm happy to do that. I'll focus on correctness of the documentation in this PR with minimal code changes. Any further changes can depend on other users' input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
