alamb commented on code in PR #7831:
URL: https://github.com/apache/arrow-datafusion/pull/7831#discussion_r1360743566
##########
datafusion/sql/src/planner.rs:
##########
@@ -46,7 +46,7 @@ use crate::utils::make_decimal_type;
/// functions referenced in SQL statements
pub trait ContextProvider {
/// Getter for a datasource
- fn get_table_provider(&self, name: TableReference) -> Result<Arc<dyn
TableSource>>;
+ fn get_table_source(&self, name: TableReference) -> Result<Arc<dyn
TableSource>>;
Review Comment:
This would be a breaking API change -- to give people time to adjust as well
as a hint on how to fix it, could you please leave a backwards compatible,
deprecated version
Perhaps something like
```rust
#[deprecated(
since = "32.0.0",
note = "please use `get_table_source` instead"
)]
fn get_table_provider(&self, name: TableReference) -> Result<Arc<dyn
TableSource>> {
self.get_table_source(name)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
