crepererum commented on code in PR #4922:
URL: https://github.com/apache/arrow-rs/pull/4922#discussion_r1360761650
##########
object_store/src/lib.rs:
##########
@@ -718,25 +718,41 @@ pub struct GetOptions {
impl GetOptions {
/// Returns an error if the modification conditions on this request are
not satisfied
- fn check_modified(
- &self,
- location: &Path,
- last_modified: DateTime<Utc>,
- ) -> Result<()> {
- if let Some(date) = self.if_modified_since {
- if last_modified <= date {
- return Err(Error::NotModified {
- path: location.to_string(),
- source: format!("{} >= {}", date, last_modified).into(),
+ ///
+ /// <https://datatracker.ietf.org/doc/html/rfc7232#section-6>
+ fn test(&self, meta: &ObjectMeta) -> Result<()> {
Review Comment:
```suggestion
fn check_modification_conditions(&self, meta: &ObjectMeta) -> Result<()>
{
```
"test" is rather non-descriptive and is easily confused w/ unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
