felipecrv commented on code in PR #38283:
URL: https://github.com/apache/arrow/pull/38283#discussion_r1360798246
##########
cpp/src/arrow/compute/kernels/scalar_string_ascii.cc:
##########
@@ -2063,7 +2063,12 @@ struct RegexSubstringReplacer {
regex_find_("(" + options_.pattern + ")", MakeRE2Options<Type>()),
regex_replacement_(options_.pattern, MakeRE2Options<Type>()) {}
- Status ReplaceString(re2::StringPiece s, TypedBufferBuilder<uint8_t>*
builder) const {
+ Status ReplaceString(std::string_view s, TypedBufferBuilder<uint8_t>*
builder) const {
+ re2::StringPiece piece(s.data(), s.length());
+ return ReplaceStringImpl(piece, builder);
+ }
+
+ Status ReplaceStringImpl(re2::StringPiece s, TypedBufferBuilder<uint8_t>*
builder) const {
Review Comment:
Fixed and pushed. I lost my pre-commit hook and missed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
