davidhcoe commented on code in PR #1192: URL: https://github.com/apache/arrow-adbc/pull/1192#discussion_r1361042707
########## csharp/src/Drivers/BigQuery/BigQueryParameters.cs: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Arrow.Adbc.Drivers.BigQuery +{ + /// <summary> + /// Parameters used for connecting to BigQuery data sources. + /// </summary> + public class BigQueryParameters + { + public const string ProjectId = "adbc.bigquery.project_id"; + public const string ClientId = "adbc.bigquery.client_id"; + public const string ClientSecret = "adbc.bigquery.client_secret"; + public const string RefreshToken = "adbc.bigquery.refresh_token"; + public const string AuthenticationType = "adbc.bigquery.auth_type"; + public const string JsonCredential = "adbc.bigquery.auth_json_credential"; + public const string AllowLargeResults = "adbc.bigquery.allow_large_results"; + public const string UseLegacySQL = "adbc.bigquery.use_legacy_sql"; + } + + /// <summary> + /// Constants used for default parameter values. + /// </summary> + public class BigQueryConstants + { + public const string UserAuthenticationType = "user"; Review Comment: it's consistent with the two types outlined on https://cloud.google.com/bigquery/docs/authentication/ and the subsequent user sample from https://github.com/googleapis/java-bigquery/blob/fa998baa32437a5e39670c5c7399c0945de56d52/samples/snippets/src/main/java/com/example/bigquery/AuthUserFlow.java#L95. I think in the future this would include a different BigQueryParameter value to ignore the refresh token route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
