tustvold commented on code in PR #7830:
URL: https://github.com/apache/arrow-datafusion/pull/7830#discussion_r1361057473
##########
datafusion/common/src/scalar.rs:
##########
@@ -744,13 +744,13 @@ impl ScalarValue {
pub fn new_primitive<T: ArrowPrimitiveType>(
a: Option<T::Native>,
d: &DataType,
- ) -> Self {
+ ) -> Result<Self> {
Review Comment:
with_data_type can still panic, I personally don't see anything wrong with
this FWIW, panic are a perfectly valid way to handle unexpected failure imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
