comphead commented on code in PR #7837:
URL: https://github.com/apache/arrow-datafusion/pull/7837#discussion_r1361218494
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -655,29 +656,36 @@ impl TryFrom<&protobuf::ScalarValue> for ScalarValue {
let schema: Schema = if let Some(schema_ref) = schema {
schema_ref.try_into()?
} else {
- return Err(Error::General("Unexpected
schema".to_string()));
+ return Err(Error::General(
Review Comment:
Should we return some of Datafusion Errors instead? Maybe IoError or
InternalError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
