jduo commented on code in PR #38266:
URL: https://github.com/apache/arrow/pull/38266#discussion_r1361249674
##########
java/vector/src/main/java/org/apache/arrow/vector/LargeVarBinaryVector.java:
##########
@@ -112,6 +113,20 @@ public byte[] get(int index) {
return result;
}
+ /**
+ * Read the value at the given position to the given output buffer.
+ * The caller is responsible for checking for nullity first.
+ *
+ * @param index position of element.
+ * @param outputBuffer the buffer to write into.
+ */
+ public void readBytes(int index, ReusableBuffer<?> outputBuffer) {
+ final long startOffset = getStartOffset(index);
+ final int dataLength =
Review Comment:
Oddly, getEndOffset() is part of BaseVariableWidthVector and _not_ part of
BaseLargeVariableWidthVector, and BLVW doesn't extend VLW.
The existing getters on this class do the narrowing cast from long to int as
well, so if this is a problem the scope is larger than this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
