davisusanibar commented on PR #37723:
URL: https://github.com/apache/arrow/pull/37723#issuecomment-1765414555
> > Thanks for opening up this PR @davisusanibar!
> > I see there are a lot of Suppressed warnings. Are they truly all needed?
(I haven't looked into all of them). I would like to see zero suppressed
warnings if possible. Otherwise, the checker doesn't feel as useful.
>
> Hi @danepitkin yes this is possible to suppress some warnings such as
`@SuppressWarnings("nullness:dereference.of.nullable")` adding more `if/else
logic`.
>
> Let me add that logic explicitly.
Hi @danepitkin I've been made changes to reduce the suppression of warning
annotations
1. When third-party libraries or methods are used for which we do not have
access, then it is necessary to suppress null warnings.
2. If you plan to call methods inside the constructor or for another method,
please consider
[annotating](https://checkerframework.org/manual/#initialization-constructor)
them with @Initialized or @Underinitialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
