pitrou commented on issue #26685: URL: https://github.com/apache/arrow/issues/26685#issuecomment-1765927505
Hi @anjakefala , while I agree the Option (1) is a good approach, I'm a bit skeptical about the proposed implementation. Two general comments: 1. This should be a general utility function, not something in `ipc` 2. I'm not sure what the point is of introducing a `ArrayBufferPayload` class that looks a lot like `ArrayData`. I would instead expect a function that takes a `ArrayData` (or `Array`) and returns a new `ArrayData` (or `Array` respectively, depending on which one is more convenient) with its buffers adjusted. I might be missing something, though. Are there some concrete constraints mandating this particular implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
