joellubi commented on PR #38256: URL: https://github.com/apache/arrow/pull/38256#issuecomment-1766076730
> We want to review `.proto` definition in this PR, right? Then we don't need to generate `go/arrow/flight/gen/flight/*.go` in this PR. We can do it in a separated PR that implements Go version of this change. Thanks for your review @kou. I would be happy to split this up into multiple PRs if that would be an acceptable path. I am new to the repo and saw other similar PRs including 2 implementations and integration tests along with the `.proto` changes, so I wanted to make sure I was following the standards. My intention is to add C++ and integration tests to this PR once there is some consensus around the `.proto` definition. If it is possible to get approval for `.proto` and implementations separately, that may be a smoother review process. Would that be a reasonable approach to take here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
