felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1362145928
##########
cpp/src/arrow/array/data.cc:
##########
@@ -233,9 +233,22 @@ BufferSpan OffsetsForScalar(uint8_t* scratch_space,
offset_type value_size) {
auto* offsets = reinterpret_cast<offset_type*>(scratch_space);
offsets[0] = 0;
offsets[1] = static_cast<offset_type>(value_size);
+ static_assert(2 * sizeof(offset_type) <= 16);
return {scratch_space, sizeof(offset_type) * 2};
}
+template <typename offset_type>
+std::pair<BufferSpan, BufferSpan> OffsetsAndSizesForScalar(uint8_t*
scratch_space,
+ offset_type
value_size) {
+ auto* offsets = scratch_space;
+ auto* sizes = scratch_space + sizeof(offset_type);
+ reinterpret_cast<offset_type*>(offsets)[0] = 0;
+ reinterpret_cast<offset_type*>(sizes)[0] = value_size;
Review Comment:
Yes. I will do it now. These utilities were added long after I started this
PR. 💀
##########
cpp/src/arrow/array/data.cc:
##########
@@ -233,9 +233,22 @@ BufferSpan OffsetsForScalar(uint8_t* scratch_space,
offset_type value_size) {
auto* offsets = reinterpret_cast<offset_type*>(scratch_space);
offsets[0] = 0;
offsets[1] = static_cast<offset_type>(value_size);
+ static_assert(2 * sizeof(offset_type) <= 16);
return {scratch_space, sizeof(offset_type) * 2};
}
+template <typename offset_type>
+std::pair<BufferSpan, BufferSpan> OffsetsAndSizesForScalar(uint8_t*
scratch_space,
+ offset_type
value_size) {
+ auto* offsets = scratch_space;
+ auto* sizes = scratch_space + sizeof(offset_type);
+ reinterpret_cast<offset_type*>(offsets)[0] = 0;
+ reinterpret_cast<offset_type*>(sizes)[0] = value_size;
Review Comment:
Yes. I will do it now. These utilities were added long after I started this
PR. 💀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
