fansehep commented on code in PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#discussion_r1363148423
##########
parquet/src/basic.rs:
##########
@@ -278,6 +279,25 @@ pub enum Encoding {
BYTE_STREAM_SPLIT,
}
+impl FromStr for Encoding {
+ type Err = ParquetError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_owned().to_uppercase().as_str() {
Review Comment:
> It seems strange that we would support parsing things like `PlAiN`
For users, whose usage is generally unobservable, I also find it odd to
support this kind of parsing like `PlAiN`, but it seems that both cases should
be supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
