mapleFU commented on code in PR #38306:
URL: https://github.com/apache/arrow/pull/38306#discussion_r1363543738
##########
cpp/src/arrow/dataset/file_parquet_encryption_test.cc:
##########
@@ -58,6 +59,13 @@ class DatasetEncryptionTest : public ::testing::Test {
// partitioning scheme. The function also checks if the written files exist
in the file
// system.
static void SetUpTestSuite() {
+#ifdef ARROW_VALGRIND
+ // Not necessary otherwise, but prevents a Valgrind leak by making sure
+ // OpenSSL initialization is done from the main thread
+ // (see GH-38304 for analysis).
+ ::parquet::encryption::EnsureBackendInitialized();
Review Comment:
I think the code works. So the user would better call
`EnsureBackendInitialized` when initializing, like initialize S3?
The current code works but would it bring some global locking or other
problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
