pitrou commented on code in PR #38314:
URL: https://github.com/apache/arrow/pull/38314#discussion_r1363851705
##########
go/arrow/cdata/cdata_fulltest.c:
##########
@@ -27,8 +27,27 @@
#include "arrow/c/helpers.h"
#include "utils.h"
+int is_little_endian()
+{
+ unsigned int x = 1;
+ char *c = (char*) &x;
+ return (int)*c;
+}
+
static const int64_t kDefaultFlags = ARROW_FLAG_NULLABLE;
+extern void releaseTestArr(struct ArrowArray* array);
+void goReleaseTestArray(struct ArrowArray* array) {
+ releaseTestArr(array);
+}
+
+void release_test_arr(struct ArrowArray* arr) {
Review Comment:
Perhaps you also want to add comments on the non-trivial test helpers, to
explain their goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
