Dandandan commented on a change in pull request #9116:
URL: https://github.com/apache/arrow/pull/9116#discussion_r554612765
##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -269,34 +276,35 @@ impl ExecutionPlan for HashJoinExec {
num_output_batches: 0,
num_output_rows: 0,
join_time: 0,
+ random_state: self.random_state.clone(),
}))
}
}
/// Updates `hash` with new entries from [RecordBatch] evaluated against the
expressions `on`,
/// assuming that the [RecordBatch] corresponds to the `index`th
fn update_hash(
- on: &HashSet<String>,
+ on: &[String],
Review comment:
`HashSet` is not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
