alamb commented on code in PR #7813:
URL: https://github.com/apache/arrow-datafusion/pull/7813#discussion_r1364528869
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -650,8 +659,15 @@ impl LogicalPlanBuilder {
///
/// let right_plan = LogicalPlanBuilder::scan("right", right_table,
None)?.build()?;
///
- /// let exprs = vec![col("left.a").eq(col("right.a")),
col("left.b").not_eq(col("right.b"))];
+ /// // Form the expression `(left.a != right.a)` AND `(left.b != right.b)`
+ /// let exprs = vec![
+ /// col("left.a").eq(col("right.a")),
+ /// col("left.b").not_eq(col("right.b"))
+ /// ];
///
+ /// // Perform the equivalent of `left INNER JOIN right ON (a != a2 AND b
!= b2)`
+ /// // finding all pairs of rows from `left` and `right` where
+ /// // where `a != a2` and `b != b2`.
Review Comment:
Good catch -- thanks @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
