felipecrv commented on issue #38090: URL: https://github.com/apache/arrow/issues/38090#issuecomment-1769517246
> I really disagree with adding all those `static_cast`. They add no value to the code, but make it less readable and more annoying to maintain. We will also quickly run into new Emscripten warnings as soon as new code handling sizes and offsets is added to the codebase. > > IMO, we should simply disable those warnings on Emscripten. I agree. It would be extremely brittle and it adds nothing to the compiled program as the downcasts happen automatically. Getting the compiler to ensure the Arrow code is 32-bit safe would require widespread use of `size_t` and less casts from `int64_t` to `size_t` instead of more casts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
