js8544 commented on PR #37536: URL: https://github.com/apache/arrow/pull/37536#issuecomment-1770941657
> I've tried to create a few benchmarks by hand and the SIMD speedups seem preserved (with AVX2; I don't have a AVX512 machine). > > That said, we don't have any benchmarks for Sum and Mean in the repo, which makes comparisons tedious. There is one for Sum [1] but it lives under Acero. I also added one for SumChecked. The results match what you observed before (about 10x slower than Sum). Since Mean is unrelated to this PR, I'll add benchmark for Mean in a separate PR. [1] https://github.com/apache/arrow/blob/main/cpp/src/arrow/acero/aggregate_benchmark.cc#L570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
