niyue commented on PR #38116:
URL: https://github.com/apache/arrow/pull/38116#issuecomment-1771223510
As discussed above, now I move the registration API into a dedicated class
called `FunctionRegistrar`, and Gandiva users will use this API for registering
external functions:
```
class GANDIVA_EXPORT FunctionRegistrar {
public:
/// \brief register a set of functions into the function registry from a
given bitcode
/// file
static arrow::Status Register(const std::vector<NativeFunction>& funcs,
const std::string& bitcode_path);
};
```
@js8544 @kou @pitrou
Could you please help to confirm if there is anything that needs to be
revised? Thanks.
P.S. Naming this class is hard for me (I am not a native English speaker),
and I don't use `XxxRegistry` because there is already a `FunctionRegistry`
class internally in Gandiva, which may be confusing if there are multiple
`Registry`. There are other alternative names, such as
`ExternalFunctionRegistry`, feel free to let me know if you have better name
than the current one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
