tustvold commented on code in PR #7855:
URL: https://github.com/apache/arrow-datafusion/pull/7855#discussion_r1365961050
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -149,70 +143,73 @@ impl<T: ArrowPrimitiveType> FieldArray for
PrimitiveArray<T> {
#[derive(Debug)]
pub struct PrimitiveValues<T: ArrowNativeTypeOp>(ScalarBuffer<T>);
-impl<T: ArrowNativeTypeOp> FieldValues for PrimitiveValues<T> {
- type Value = T;
-
+impl<T: ArrowNativeTypeOp> CursorValues for PrimitiveValues<T> {
fn len(&self) -> usize {
self.0.len()
}
- #[inline]
- fn compare(a: &Self::Value, b: &Self::Value) -> Ordering {
- T::compare(*a, *b)
+ fn eq(l: &Self, l_idx: usize, r: &Self, r_idx: usize) -> bool {
+ l.0[l_idx].is_eq(r.0[r_idx])
}
- #[inline]
- fn value(&self, idx: usize) -> &Self::Value {
- &self.0[idx]
+ fn compare(l: &Self, l_idx: usize, r: &Self, r_idx: usize) -> Ordering {
+ l.0[l_idx].compare(r.0[r_idx])
}
}
-impl<T: ByteArrayType> FieldArray for GenericByteArray<T> {
- type Values = Self;
+pub struct ByteArrayValues<T: OffsetSizeTrait> {
+ offsets: OffsetBuffer<T>,
+ values: Buffer,
+}
- fn values(&self) -> Self::Values {
- // Once https://github.com/apache/arrow-rs/pull/4048 is released
- // Could potentially destructure array into buffers to reduce codegen,
- // in a similar vein to what is done for PrimitiveArray
- self.clone()
+impl<T: OffsetSizeTrait> ByteArrayValues<T> {
+ fn value(&self, idx: usize) -> &[u8] {
+ let end = self.offsets[idx + 1].as_usize();
Review Comment:
We could, I suspect that LLVM is smart enough to realise that this can't
overflow, as `self.offsets().len() < isize::MAX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
