kou commented on PR #4957:
URL: https://github.com/apache/arrow-rs/pull/4957#issuecomment-1771707301
How about adding `ci/scripts/integration_build.sh` to apache/arrow and use
it in apache/arrow's `docker-compose.yml` and apache/arrow-rs's
`.github/workflows/integration.yml`?
```diff
diff --git a/docker-compose.yml b/docker-compose.yml
index e54c609e5..6b5b777c9 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -1734,18 +1734,8 @@ services:
# Tell Archery where the arrow C++ binaries are located
ARROW_CPP_EXE_PATH: /build/cpp/debug
ARROW_GO_INTEGRATION: 1
- ARROW_JAVA_CDATA: "ON"
- JAVA_JNI_CMAKE_ARGS: >-
- -DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF
- -DARROW_JAVA_JNI_ENABLE_C=ON
command:
- ["/arrow/ci/scripts/rust_build.sh /arrow /build &&
- /arrow/ci/scripts/cpp_build.sh /arrow /build &&
- /arrow/ci/scripts/csharp_build.sh /arrow /build &&
- /arrow/ci/scripts/go_build.sh /arrow &&
- /arrow/ci/scripts/java_jni_build.sh /arrow $${ARROW_HOME} /build
/tmp/dist/java/$$(arch) &&
- /arrow/ci/scripts/java_build.sh /arrow /build /tmp/dist/java &&
- /arrow/ci/scripts/js_build.sh /arrow /build &&
+ ["/arrow/ci/scripts/integration_build /arrow /build &&
/arrow/ci/scripts/integration_arrow.sh /arrow /build"]
################################ Docs
#######################################
```
```diff
diff --git a/.github/workflows/integration.yml
b/.github/workflows/integration.yml
index 62d2d2cb1a..0c3e4213fd 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -88,42 +88,10 @@ jobs:
with:
path: rust
fetch-depth: 0
- - name: Install pythonnet
- run: conda run --no-capture-output pip install pythonnet
- - name: Install archery
- run: conda run --no-capture-output pip install -e
dev/archery[integration]
- - name: Make build directory
- run: mkdir /build
- - name: Build Rust
- run: conda run --no-capture-output ci/scripts/rust_build.sh $PWD
/build
- - name: Build C++
- run: conda run --no-capture-output ci/scripts/cpp_build.sh $PWD
/build
- - name: Build C#
- run: conda run --no-capture-output ci/scripts/csharp_build.sh $PWD
/build
- - name: Build Go
- run: conda run --no-capture-output ci/scripts/go_build.sh $PWD
- - name: Build Java
- run: conda run --no-capture-output ci/scripts/java_build.sh $PWD
/build
- - name: Build JS
- run: conda run --no-capture-output ci/scripts/js_build.sh $PWD
/build
+ - name: Build
+ run: conda run --no-capture-output ci/scripts/integration_build.sh
$PWD /build
- name: Run integration tests
- run: |
- conda run --no-capture-output archery integration \
- --run-flight \
- --run-c-data \
- --run-ipc \
- --with-cpp=1 \
- --with-csharp=1 \
- --with-java=1 \
- --with-js=1 \
- --with-go=1 \
- --with-rust=1 \
- --gold-dirs=testing/data/arrow-ipc-stream/integration/0.14.1 \
- --gold-dirs=testing/data/arrow-ipc-stream/integration/0.17.1 \
-
--gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-bigendian \
-
--gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-littleendian \
-
--gold-dirs=testing/data/arrow-ipc-stream/integration/2.0.0-compression \
-
--gold-dirs=testing/data/arrow-ipc-stream/integration/4.0.0-shareddict
+ run: conda run --no-capture-output ci/scripts/integration_build.sh
$PWD /build
# test FFI against the C-Data interface exposed by pyarrow
pyarrow-integration-test:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
