tustvold commented on code in PR #4962: URL: https://github.com/apache/arrow-rs/pull/4962#discussion_r1366857069
########## arrow-schema/src/fields.rs: ########## @@ -41,7 +41,7 @@ use std::sync::Arc; #[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] #[cfg_attr(feature = "serde", serde(transparent))] -pub struct Fields(Arc<[FieldRef]>); +pub struct Fields(Arc<Vec<FieldRef>>); Review Comment: This is not necessary, as a result of unsized coercion - https://doc.rust-lang.org/std/ops/trait.CoerceUnsized.html https://docs.rs/arrow-schema/latest/arrow_schema/struct.SchemaBuilder.html provides an easy to use interface on top of this, but `Fields` also implements `FromIterator` and so can be collected into directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
