alamb commented on PR #3158: URL: https://github.com/apache/arrow-datafusion/pull/3158#issuecomment-1773135903
> @alamb do you prefer to add these test cases? I could do the rebase and push again. Otherwise I think we could close the pr now as it's been solve. I think these tests would be very valuable as our sql coverage of time is pretty low at the moment. Perhaps you could make a `time.slt` that is similar to [`dates.slt`](https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/dates.slt) and [`timestamp.slt`](https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/timestamps.slt)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
