NGA-TRAN commented on code in PR #7890:
URL: https://github.com/apache/arrow-datafusion/pull/7890#discussion_r1367328822
##########
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##########
@@ -135,8 +135,7 @@ impl FileScanConfig {
table_cols_stats.push(self.statistics.column_statistics[idx].clone())
} else {
let partition_idx = idx - self.file_schema.fields().len();
- let (name, dtype) = &self.table_partition_cols[partition_idx];
- table_fields.push(Field::new(name, dtype.to_owned(), false));
+
table_fields.push(self.table_partition_cols[partition_idx].to_owned());
Review Comment:
And this where we convert `table_partition_cols` to `Field`
##########
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##########
@@ -101,7 +101,7 @@ pub struct FileScanConfig {
/// all records after filtering are returned.
pub limit: Option<usize>,
/// The partitioning columns
- pub table_partition_cols: Vec<(String, DataType)>,
+ pub table_partition_cols: Vec<Field>,
Review Comment:
Here is the key change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
