jonkeane commented on code in PR #38377: URL: https://github.com/apache/arrow/pull/38377#discussion_r1367465051
########## r/R/dataset.R: ########## @@ -527,6 +527,9 @@ names.Dataset <- function(x) names(x$schema) #' @export dim.Dataset <- function(x) c(x$num_rows, x$num_cols) +#' @export +dimnames.Dataset <- function(x) list(NULL, names(x)) Review Comment: We might consider a message here that tells folks that the `NULL` doesn't mean there are none. But then again dbplyr doesn't do that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
