bkietz commented on a change in pull request #9130:
URL: https://github.com/apache/arrow/pull/9130#discussion_r555173519
##########
File path: cpp/src/arrow/dataset/partition.cc
##########
@@ -230,9 +236,9 @@ std::vector<KeyValuePartitioning::Key>
DirectoryPartitioning::ParseKeys(
return keys;
}
-inline util::optional<int> NextValid(const std::vector<Scalar*>& values, int
first_null) {
+inline util::optional<int> NextValid(const ScalarVector& values, int
first_null) {
auto it = std::find_if(values.begin() + first_null + 1, values.end(),
- [](Scalar* v) { return v != nullptr; });
+ [](const std::shared_ptr<Scalar> v) { return v !=
nullptr; });
Review comment:
yes, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
