niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1367573318
##########
cpp/src/gandiva/llvm_generator_test.cc:
##########
@@ -115,4 +117,14 @@ TEST_F(TestLLVMGenerator, TestAdd) {
EXPECT_EQ(out_bitmap, 0ULL);
}
+TEST_F(TestLLVMGenerator, VerifyExtendedPCFunctions) {
+ ARROW_EXPECT_OK(LoadTestLLVMIR());
Review Comment:
After making LLVMGenerator to accept a function registry, which itself is
instantiable, now this test is updated and it will be independent with other
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
