berkaysynnada commented on issue #7882: URL: https://github.com/apache/arrow-datafusion/issues/7882#issuecomment-1773810387
> Thanks @berkaysynnada -- note I just proposed three relatively small changes . Perhaps you have some time to look at them: > > * [Minor: Clarify Boolean `Interval` handling and verify it with a test #7885](https://github.com/apache/arrow-datafusion/pull/7885) > * [Support Interval analysis for `OR` expressions #7884](https://github.com/apache/arrow-datafusion/pull/7884) > * [Minor: Fix bug in `AND` interval analysis tests (not code), and add more coverage #7886](https://github.com/apache/arrow-datafusion/pull/7886) > > > I also plan to move the code into a more accessible place (possibly datafusion_expr) > > What would you think about making a `datafusion-interval` crate to hold the interval analysis library ? that would keep it nicely isolated and likely improve the development cycle time (I found it quite painful to work on in datafusion-physical-expr) Thank you for the care and effort you have put into this issue. I tried to answer the current behavior and how it should actually be in the reviews you opened. However, as I mentioned in them, I am currently working on a comprehensive interval library update. It will eliminate many of the bugs you noticed and provide a more open, error-free API for users. I don't want to keep you waiting, but I think it will be easier to solve these issues after I quickly finalize my PR and present it to you. As for making the new interval crate, it would be better to answer after discussing it with my teammates. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
