devinjdangelo commented on code in PR #7896:
URL: https://github.com/apache/arrow-datafusion/pull/7896#discussion_r1367911373
##########
datafusion/core/src/datasource/file_format/write/demux.rs:
##########
@@ -310,7 +311,37 @@ fn compute_partition_keys_by_row<'a>(
for i in 0..rb.num_rows() {
partition_values.push(array.value(i));
}
- }
+ },
+ DataType::Dictionary(key_type, _) => {
+ match **key_type{
+ DataType::UInt16 => {
Review Comment:
Thanks @suremarc for the pointer to that macro! I updated this PR and it
seems to work as expected!
I also added a new test based on a dictionary encoded parquet file from one
of the testing submodules. It is working without error, but the values look a
bit off. Not sure at this point if related to the downcasting or something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
