js8544 commented on issue #38386: URL: https://github.com/apache/arrow/issues/38386#issuecomment-1774125995
1. Dictionary `Array` sorting was implemented in #35280, but not for `ChunkedArray`, `RecordBatch` and `Table`. You can checked out the `SortIndicesMetaFunction` class in vector_sort.cc for existing implementations, in particular the concrete `RadixRecordBatchSorter` and `MultipleKeyRecordBatchSorter`. 2. Supporting `equal` for null types won't be hard. It should be added in `scalar_compare.cc`. A kernel should be added in the `MakeCompareFunction` function. For the sake of consistency, I'd assume the compare kernels should just return a NullArray for NullArray inputs? So I guess registering a trivial kernel that returns the first input should be enough? `codegen_internal.h/cc` contains utility functions for compute kernels so they are probably not the real source of your problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
