indigophox commented on PR #34817: URL: https://github.com/apache/arrow/pull/34817#issuecomment-1774225662
Sorry I was off on vacation, just grinding through the refactor around the new serialization stuff. Had to stop off and learn some C++17 I didn't know I didn't know. Random thought: Might be useful to have a virtual superclass (probably just 1 not 2 for request/response) for all of the request/response messages, which would also eliminate the duplication of the PackActionResult functions, or even have a non-virtual .SerializeToBuffer() in the superclass and skip PackActionResult entirely :) I'm sure you're swimming in free time, just figured this is a simplifying thing while the serialization is being neatly factored out of the way. Will push and/or update you in the next few days once I've finished the refactor of my change around the serialization stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
