tustvold commented on code in PR #4959:
URL: https://github.com/apache/arrow-rs/pull/4959#discussion_r1368471967
##########
arrow-schema/src/schema.rs:
##########
@@ -332,6 +332,28 @@ impl Schema {
.iter()
.all(|(k, v1)| self.metadata.get(k).map(|v2| v1 ==
v2).unwrap_or_default())
}
+
+ /// Remove field by name and return it. Recommend to use [`SchemaBuilder`]
+ /// if you are looking to remove multiple columns, as this will save
allocations.
+ ///
+ /// ```
+ /// use arrow_schema::{DataType, Field, Schema};
+ /// let mut schema = Schema::new(vec![
+ /// Field::new("a", DataType::Boolean, false),
+ /// Field::new("b", DataType::Int8, false),
+ /// Field::new("c", DataType::Utf8, false),
+ /// ]);
+ /// assert_eq!(schema.fields.len(), 3);
+ /// assert_eq!(schema.remove_field_with_name("b").unwrap(),
Field::new("b", DataType::Int8, false).into());
+ /// assert_eq!(schema.fields.len(), 2);
+ /// ```
+ pub fn remove_field_with_name(&mut self, name: &str) -> Option<FieldRef> {
Review Comment:
What do you think of only providing a remove by index and let people use
column_by_name? I think this would be more consistent?
##########
arrow-schema/src/fields.rs:
##########
@@ -98,6 +98,29 @@ impl Fields {
.zip(other.iter())
.all(|(a, b)| Arc::ptr_eq(a, b) || a.contains(b))
}
+
+ /// Remove a field by index and return it.
+ /// ```
+ /// use arrow_schema::{DataType, Field, Fields};
+ /// let mut fields = Fields::from(vec![
+ /// Field::new("a", DataType::Boolean, false),
+ /// Field::new("b", DataType::Int8, false),
+ /// Field::new("c", DataType::Utf8, false),
+ /// ]);
+ /// assert_eq!(fields.len(), 3);
+ /// assert_eq!(fields.remove(1).unwrap(), Field::new("b", DataType::Int8,
false).into());
+ /// assert_eq!(fields.len(), 2);
+ /// ```
+ pub fn remove(&mut self, index: usize) -> Option<FieldRef> {
Review Comment:
We could use SchemaBuilder here also, this should also panic for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
