lidavidm commented on code in PR #1183:
URL: https://github.com/apache/arrow-adbc/pull/1183#discussion_r1368916317
##########
csharp/src/Client/SchemaConverter.cs:
##########
@@ -58,15 +61,20 @@ public static DataTable ConvertArrowSchema(Schema schema,
AdbcStatement adbcStat
row[SchemaTableColumn.ColumnName] = f.Name;
row[SchemaTableColumn.ColumnOrdinal] = columnOrdinal;
row[SchemaTableColumn.AllowDBNull] = f.IsNullable;
- row[SchemaTableColumn.ProviderType] = f.DataType;
+ row[ArrowTypeName] = f.DataType;
Type t = ConvertArrowType(f);
row[SchemaTableColumn.DataType] = t;
+ if (f.HasMetadata && f.Metadata.ContainsKey("logicalType"))
Review Comment:
In general, the other implementations have the driver convert the database
type to the proper Arrow type up front (e.g. Snowflake numerics get turned into
Arrow decimals), then have a single consistent mapping for Arrow type to
language-native type. That way we don't have to worry about multiple conversion
targets in each driver, or asking clients to know what driver they are using
(isn't ADO.NET meant to abstract some of those details?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
