lidavidm commented on code in PR #38331:
URL: https://github.com/apache/arrow/pull/38331#discussion_r1368973651
##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightEndpoint.java:
##########
@@ -54,13 +57,22 @@ public FlightEndpoint(Ticket ticket, Location... locations)
{
* Constructs a new endpoint with an expiration time.
*
* @param ticket A ticket that describe the key of a data stream.
+ * @param expirationTime (optional) When this endpoint expires.
* @param locations The possible locations the stream can be retrieved from.
*/
public FlightEndpoint(Ticket ticket, Instant expirationTime, Location...
locations) {
Review Comment:
Hmm, I think it's OK to keep it
##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightInfo.java:
##########
@@ -94,6 +97,23 @@ public FlightInfo(Schema schema, FlightDescriptor
descriptor, List<FlightEndpoin
*/
public FlightInfo(Schema schema, FlightDescriptor descriptor,
List<FlightEndpoint> endpoints, long bytes,
long records, boolean ordered, IpcOption option) {
+ this(schema, descriptor, endpoints, bytes, records, ordered, option, null);
+ }
+
+ /**
+ * Constructs a new instance.
+ *
+ * @param schema The schema of the Flight
+ * @param descriptor An identifier for the Flight.
+ * @param endpoints A list of endpoints that have the flight available.
+ * @param bytes The number of bytes in the flight
+ * @param records The number of records in the flight.
+ * @param ordered Whether the endpoints in this flight are ordered.
+ * @param option IPC write options.
+ * @param appMetadata Metadata to send along with the flight
+ */
+ public FlightInfo(Schema schema, FlightDescriptor descriptor,
List<FlightEndpoint> endpoints, long bytes,
Review Comment:
I think it's OK to just keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
