judahrand commented on code in PR #34234:
URL: https://github.com/apache/arrow/pull/34234#discussion_r1369185194


##########
python/pyarrow/_dataset.pyx:
##########
@@ -874,6 +874,63 @@ cdef class Dataset(_Weakrefable):
             output_type=InMemoryDataset
         )
 
+    def join_asof(self, right_dataset, on, by, tolerance, right_on=None, 
right_by=None):
+        """
+        Perform an asof join between this dataset and another one.
+
+        Result of the join will be a new Dataset, where further
+        operations can be applied.
+
+        Parameters
+        ----------
+        right_dataset : dataset
+            The dataset to join to the current one, acting as the right dataset
+            in the join operation.
+        on : str
+            The column from current dataset that should be used as the on key
+            of the join operation left side.
+
+            An inexact match is used on the “on” key.i.e., a row is considered 
a
+            match iff left_on - tolerance <= right_on <= left_on.
+
+            The input table must be sorted by the “on” key. Must be a single
+            field of a common type.
+
+            Currently, the “on” key must be an integer, date, or timestamp 
type.
+        by : str or list[str]
+            The columns from current dataset that should be used as the keys
+            of the join operation left side.

Review Comment:
   
https://github.com/apache/arrow/pull/34234/commits/acb082e8da4647c13a60484f654d7ca1425f7f6e



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to