alamb commented on code in PR #7870:
URL: https://github.com/apache/arrow-datafusion/pull/7870#discussion_r1369249398
##########
datafusion/common/src/dfschema.rs:
##########
@@ -102,8 +217,12 @@ impl DFSchema {
));
}
}
+
+ let fields_index = build_index(&fields);
Review Comment:
If the index is built for all DFSchema that are created, I wonder if that
will be too much overhead. Maybe we could consider creating it on first use 🤔
or finding some way to canonicalize / cache the map
##########
datafusion/common/src/dfschema.rs:
##########
@@ -102,8 +217,12 @@ impl DFSchema {
));
}
}
+
+ let fields_index = build_index(&fields);
Review Comment:
If the index is built for all DFSchema that are created, I wonder if that
will be too much overhead. Maybe we could consider creating it on first use 🤔
or finding some way to canonicalize / cache the map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
