jayzhan211 commented on code in PR #7862:
URL: https://github.com/apache/arrow-datafusion/pull/7862#discussion_r1369340102
##########
datafusion/physical-expr/src/aggregate/array_agg_distinct.rs:
##########
@@ -308,146 +304,4 @@ mod tests {
check_merge_distinct_array_agg(col1, col2, expected, DataType::Int32)
}
-
- #[test]
- fn distinct_array_agg_nested() -> Result<()> {
Review Comment:
@alamb
Since update_batch() of DistinctArrayAggAccumulator only accepts non-list
after the change. Nested array in these tests is not allowed.
Should I just delete the test or add an assertion to ensure we get Err in
this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
